bazelbuild/bazel

bazel sync --experimental_repository_resolved_file is formatted differently than buildifier

Open

#14,454 opened on Dec 20, 2021

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Java (4,465 forks)batch import
P3help wantednot staleteam-ExternalDepstype: feature request

Repository metrics

Stars
 (25,384 stars)
PR merge metrics
 (Avg merge 22d 20h) (77 merged PRs in 30d)

Description

Description of the problem / feature request:

The output of bazel sync --experimental_repository_resolved_file is formatted differently than buildifier formats .bzl files. If both sync and buildifer are used in a pre-commit hook this can cause the hooks to continuously fail.

Feature requests: what underlying problem are you trying to solve with this feature?

Consistent formatting of bazel files and not having pre-commit hooks continuously fail.

Bugs: what's the simplest, easiest way to reproduce this bug? Please provide a minimal example if possible.

Run bazel-sync --experimental_repository_resolved_file=resolved.bzl and then buildifier resolved.bzl and observe that the file has changed in formatting.

What operating system are you running Bazel on?

Debian Linux.

What's the output of bazel info release?

release 4.2.2

Have you found anything relevant by searching the web?

No

Any other information, logs, or outputs that you want to share?

No

Contributor guide

Research direction
Compare the formatting output of `buildifier` with the output of `bazel sync experimental repository resolved file`, identify the differences, and modify the sync output to match buildifier formatting.
Tech stack
java
Domain
build systemdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
BazelbuildifierStarlark
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60