bazelbuild/bazel

Building a target with a Bazel aspect overwrites the Target command line printout

Open

#10,530 opened on Jan 6, 2020

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Java (25,384 stars) (4,465 forks)batch import
help wantedteam-Coretype: buguntriaged

Description

Description of the problem / feature request:

Building a target with a Bazel aspect overwrites the Target command line printout. The Target printout previously contained information such as the path to the generated build artifact.

For example:

$ bazel build :grpc_health_v1_proto --aspects=//rules:proto_linter.bzl%proto_linter_aspect --output_groups=+proto_lint_out

INFO: Writing tracer profile to
...
INFO: Found 1 target...
Target //idl/x/go/health/proto:grpc_health_v1_proto up-to-date:
  bazel-bin/idl/x/go/health/proto/grpc_health_v1_proto-descriptor-set.proto.bin
INFO: Elapsed time: 0.582s, Critical Path: 0.00s
INFO: 0 processes.
INFO: Build completed successfully, 1 total action

Has a different command line output then

$ bazel build :grpc_health_v1_proto

INFO: Writing tracer profile to 
...
INFO: Found 1 target...
Aspect //rules:proto_linter.bzl%proto_linter_aspect of //idl/x/go/health/proto:grpc_health_v1_proto up-to-date:
  bazel-bin/idl/xl/go/health/proto/grpc_health_v1_proto.protolint_result
INFO: Elapsed time: 0.493s, Critical Path: 0.00s
INFO: 0 processes.
INFO: Build completed successfully, 1 total action

The path to the aspect build artifact is printed, but the original build artifact path is lost.

I believe this issue is related to this [logic](https://source.bazel.build/bazel/+/master:src/main/java/com/google/devtools/build/lib/buildtool/BuildResultPrinter.java;bpv=;l=81 l) in Bazel.

Feature requests: what underlying problem are you trying to solve with this feature?

Building a Bazel target with an aspect should preserve the build target output message.

What operating system are you running Bazel on?

darwin18.0

What's the output of bazel info release?

release 1.1.0

Have you found anything relevant by searching the web?

I haven't found a relevant discussion online as of yet.

I believe this issue is related to this [logic](https://source.bazel.build/bazel/+/master:src/main/java/com/google/devtools/build/lib/buildtool/BuildResultPrinter.java;bpv=;l=81 l) in Bazel.

Contributor guide

Tech stack
java
Domain
build systemcli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaBazel build systemBuild output logging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the BuildResultPrinter.java file, specifically the logic around line 81 that handles printing target information. Understand how aspects affect the output and modify the code to preserve the original target artifact path when aspects are used. Check if there are any existing tests for this behavior.