Bazel targets aren't created for labels using shorthand notation

Open
#98 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
45/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
swift
Domain
build-system

Research direction

Start at the label filtering code shown in the issue, where specifiedLabels is compared with each Xcode target label. Trace how labels are represented in the XCHammer configuration and target data, then verify that shorthand and full label syntax select the same Bazel targets. Done means shorthand labels no longer get missed.

Written by the indexing model from the issue text.

Description

Currently XCHammer creates Bazel targets by the labels specified in the XCHammer config.

Since we do a naive string comparison, it will miss labels that aren't using the full label syntax:

            return allXCTargets
                .filter { specifiedLabels.contains($0.value.xcodeTarget.label) }
                .map { $0.value.xcodeTarget }
Dominant language
Swift
Stars
314
Forks
45
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from bazel-xcode/xchammer

All issues in bazel-xcode/xchammer

Similar issues

More Swift issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.