Rounding errors or smth

Open
#8 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
25/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
ruby

Research direction

Start with the request-time instrumentation that emits the shown Rack.Request metrics and inspect how negative values are validated. Compare the calculations for the listed controller metrics to determine whether these values are rounding artifacts or invalid timings. Done should include confirmed expected behavior and an appropriate regression test or explanation.

Written by the indexing model from the issue text.

Description

Is that okay or not?

9 Jun 19:38:53 - DEBUG: Bad line: -0.046373953111469746,ms,@0.1 in msg "Rack.Request.Controllers.countries.Time.idle:-0.046373953111469746|ms|@0.1"
9 Jun 19:38:56 - DEBUG: Bad line: -0.09394823436741717,ms,@0.1 in msg "Rack.Request.Actions.countries.index.text/html+[].Time.idle:-0.09394823436741717|ms|@0.1"
9 Jun 19:40:35 - DEBUG: Bad line: -0.0016081093635875732,ms,@0.1 in msg "Rack.Request.Actions.random.index.none+[].Time.idle:-0.0016081093635875732|ms|@0.1"
9 Jun 19:40:35 - DEBUG: Bad line: -0.051120046875439584,ms,@0.1 in msg "Rack.Request.All.Time.idle:-0.051120046875439584|ms|@0.1"
9 Jun 19:41:17 - DEBUG: Bad line: -0.055048562498996034,ms,@0.1 in msg "Rack.Request.Controllers.frags.Time.idle:-0.055048562498996034|ms|@0.1"
9 Jun 19:41:17 - DEBUG: Bad line: -0.055048562498996034,ms,@0.1 in msg "Rack.Request.Actions.frags.index.text/html+[].Time.idle:-0.055048562498996034|ms|@0.1"
9 Jun 19:41:23 - DEBUG: Bad line: -0.8728879189081986,ms,@0.1 in msg "Rack.Request.Actions.countries.index.text/html+[].Time.pct.idle:-0.8728879189081986|ms|@0.1"
9 Jun 19:41:24 - DEBUG: Bad line: -0.06603962500000193,ms,@0.1 in msg "Rack.Request.Controllers.frags.Time.idle:-0.06603962500000193|ms|@0.1"
9 Jun 19:42:34 - DEBUG: Bad line: -0.39619290358255427,ms,@0.1 in msg "Rack.Request.All.Time.pct.idle:-0.39619290358255427|ms|@0.1"
9 Jun 19:43:00 - DEBUG: Bad line: -0.014542890625307336,ms,@0.1 in msg "Rack.Request.Controllers.random.Time.idle:-0.014542890625307336|ms|@0.1"
9 Jun 19:43:00 - DEBUG: Bad line: -0.7258155233490782,ms,@0.1 in msg "Rack.Request.All.Time.pct.idle:-0.7258155233490782|ms|@0.1"
9 Jun 19:43:39 - DEBUG: Bad line: -2.0303885993533575,ms,@0.1 in msg "Rack.Request.All.Time.pct.idle:-2.0303885993533575|ms|@0.1"
9 Jun 19:44:14 - DEBUG: Bad line: -0.014303578122053295,ms,@0.1 in msg "Rack.Request.Controllers.random.Time.idle:-0.014303578122053295|ms|@0.1"
9 Jun 19:45:51 - DEBUG: Bad line: -0.9865908093262699,ms,@0.1 in msg "Rack.Request.All.Time.pct.idle:-0.9865908093262699|ms|@0.1"
9 Jun 19:45:51 - DEBUG: Bad line: -0.0034391406225040555,ms,@0.1 in msg "Rack.Request.Controllers.random.Time.idle:-0.0034391406225040555|ms|@0.1"
9 Jun 19:45:51 - DEBUG: Bad line: -0.0034391406225040555,ms,@0.1 in msg "Rack.Request.Actions.random.index.none+[].Time.idle:-0.0034391406225040555|ms|@0.1"

p.s. Where frags and random are controller names

Dominant language
Ruby
Stars
193
Forks
23
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from basecamp/trashed

All issues in basecamp/trashed

Similar issues

More Ruby issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.