fix: set --fault proofs CLI default to true for built in fault-proof networks

Open Beginner friendly
#87 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
88/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
go
Domain
blockchain, cli

Research direction

Open main.go and locate the flag.BoolVar declaration for --fault-proofs. Change its default to true, matching the faultProofs setting on the four built-in networks. Done means the shown withdrawer command no longer requires users to provide --fault-proofs explicitly.

Written by the indexing model from the issue text.

Description

All four built-in networks (base-mainnet, base-sepolia, op-mainnet, op-sepolia) have faultProofs: true and their l2oo-address set to 0x0. However, the --fault-proofs CLI flag defaults to false.

A user running a simple command like:

withdrawer --network base-mainnet --withdrawal --rpc --private-key

...gets a crash with: "Fault proofs are required on this network, please provide the --fault-proofs flag".

Since all built-in networks use fault proofs, the default should be true to match the network configurations.

Fix:
Change the default from false to true in main.go:
go
flag.BoolVar(&faultProofs, "fault-proofs", true, "Use fault proofs")

Dominant language
Go
Stars
537
Forks
373
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from base/withdrawer

All issues in base/withdrawer

Similar issues

More Go issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.