bannzai/SpreadsheetView

Present a popover on tapped cell

Open

#167 opened on Dec 7, 2017

View on GitHub
 (1 comment) (0 reactions) (1 assignee)HTML (3,451 stars) (446 forks)batch import
help wanted

Description

Expected Behavior

Actual Behavior

While presenting a popover over a cell that was tapped on, doing this should give the rect of the tapped cell -

let rect = self.gradebookView.rectForItem(at: indexPath)
let rectInView = self.gradebookView.convert(rect, to: self.view)

but it seems the rect being obtained after converting it to the parent view's coordinate is not right and the popover always ends up getting opened someplace else and sometimes even out of the view.

Steps to Reproduce the Problem

  1. Tap on a cell
  2. Get the rect of the cell in didSelectItemAt:indexPath and convert that rect to the parent view's coordinates
  3. Presenting the popover with that sourceRect shows the popover over a completely different cell.

Specifications

  • Xcode version: 9.1
  • iOS version: 11.1
  • Dependency manager + version: 0.8.4

Contributor guide

Tech stack
swiftios
Domain
mobile
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Familiarity with iOS UIKitUnderstanding coordinate systems
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate the coordinate conversion in SpreadsheetView, specifically the rectForItem: and convert:to: methods. Check if the rect is correct before conversion. Look at the popover presentation code. The issue might be related to content offset or scroll view insets. Review the SpreadsheetView source code and any related comments or linked PRs.
Present a popover on tapped cell · bannzai/SpreadsheetView#167 | Good First Issue