:wheelchair: a11y(component): bal-dropdown aria-label default value

Open Beginner friendly
#2,029 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
typescript
Domain
accessibility

Research direction

Start by locating the bal-dropdown component and inspect how its default aria-label is assigned. Verify the component no longer provides a default label and that users can still define one, including when the dropdown is disabled.

Written by the indexing model from the issue text.

Description

✨ feature
Description of this issue

The bal-dropdown components seem to have a default aria-label set to "Ouvrir," (Open, or Öffnen depending on set language) which doesn't make much sense and can be misleading—for instance, when the dropdown is disabled.

How to fix it

Do not define a default aria-label for bal-dropdown components; allow the user to define it as needed.

Code Reproduction URL

https://homedigital.dev-wap-lu.balgroupit.com/

Additional Information

No response

Code of Conduct
  • I agree to follow this project's Code of Conduct
Dominant language
TypeScript
Stars
114
Forks
30
Avg merge
22h 9m
Merged PRs (30d)
70

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from baloise/design-system

All issues in baloise/design-system

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.