ballercat/walt

Top Level StringLiteral constants

Open

#115 opened on May 1, 2018

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (4,637 stars) (155 forks)batch import
buggood first issuehelp wanted

Description

Bug Report

Overview

Top level StringLiterals fail validation, they should not. Instead, they should compile out to a constant i32 pointer to the data location for a string.

Expected

Top level strings are allowed

Actual

Strings in top-level constants throw validation warnings.

Example

const memory: Memory<{ initial: 1 }>;
const myString: i32 = 'hello world';
export function test(): i32 {
  return myString;
}

Contributor guide