balderdashy/sails

Assets generation stops prematurely when migrate prompt answered quickly

Open

#6,998 opened on May 24, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (22,778 stars) (1,953 forks)batch import
help wantedhelpful info or workaround

Description

Node version: 12.16.1 Sails version (sails): 1.2.4 ORM hook version (sails-hook-orm): Sockets hook version (sails-hook-sockets): Organics hook version (sails-hook-organics): Grunt hook version (sails-hook-grunt): 1.0.4 Uploads hook version (sails-hook-uploads): DB adapter & version (e.g. sails-mysql@5.55.5): Skipper adapter & version (e.g. skipper-s3@5.55.5):

When lifting sails in development mode, and a migrate setting is not provided, the command prompt asks what you want to do about migration. Meanwhile, asset generation/building continues in the background.

However, if you answer this prompt before asset generation is finished, asset generation terminates prematurely. This results in missing asset files in .tmp/public .

We prefer to not specify a migrate setting because we want to use the prompt to determine how to migrate. If we made no changes to the schema, we will launch in dev under safe. Otherwise, we will use alter, and in rare cases, drop.

Contributor guide

Tech stack
javascriptnodejs
Domain
backendfull stack
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsSails fundamentals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the Sails lift process, specifically the asset generation that runs in the background while the migrate prompt is displayed. Look at the Grunt configuration (likely in tasks/register/) and the lift command implementation (probably in app.js or sails/lib/app/) to understand how asset building is triggered and how the migrate prompt interacts. The issue suggests that when the user answers the prompt quickly, the asset build stops prematurely. Check for any promise or callback that might be resolving early. Review comments in the issue for any hints.