balderdashy/sails

sails cannot deal the error "UnhandledPromiseRejectionWarning",but I find express done

Open

#6,988 opened on May 9, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (22,778 stars) (1,953 forks)batch import
help wantedmore info please

Description

Node version: v10.15.0 Sails version (sails): v0.12.14

I find express can deal the error "UnhandledPromiseRejectionWarning" by change layer

The code like this: const Layer = require('express/lib/router/layer'); Object.defineProperty(Layer.prototype, 'handle', { enumerable: true, get() { return this.__handle; }, set(fn) { if (fn.length === 4) { this.__handle = fn; } else { this.__handle = (req, res, next) => Promise.resolve() .then(() => fn(req, res, next)) .catch(next); } }, });

Contributor guide

Tech stack
nodejsexpress
Domain
backend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Node.js fundamentalsExpress error handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate how Express handles UnhandledPromiseRejection in Layer.prototype.handle. The user provided a workaround using a setter on Layer.prototype.handle. Review Sails' error handling middleware and see where similar promise rejection handling can be added. Consider adding similar logic to Sails' router layer or ensuring that async route handlers are wrapped to catch promise rejections.