balderdashy/sails

sails cannot deal the error "UnhandledPromiseRejectionWarning",but I find express done

Open

#6,988 opened on May 9, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (1,953 forks)batch import
help wantedmore info please

Repository metrics

Stars
 (22,778 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Node version: v10.15.0 Sails version (sails): v0.12.14

I find express can deal the error "UnhandledPromiseRejectionWarning" by change layer

The code like this: const Layer = require('express/lib/router/layer'); Object.defineProperty(Layer.prototype, 'handle', { enumerable: true, get() { return this.__handle; }, set(fn) { if (fn.length === 4) { this.__handle = fn; } else { this.__handle = (req, res, next) => Promise.resolve() .then(() => fn(req, res, next)) .catch(next); } }, });

Contributor guide

Research direction
Investigate how Sails handles errors in middleware and compare with Express's layer handling. The user suggests patching Express's Layer to catch promises. Look into Sails' middleware pipeline and how it wraps Express, and check for existing error handling for promises.
Tech stack
javascriptnodejsexpress
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsExpressSails
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50