balderdashy/sails

How to handle a route with a dot in route param

Open

#6,954 opened on Feb 25, 2020

View on GitHub
 (10 comments) (0 reactions) (0 assignees)JavaScript (22,778 stars) (1,953 forks)batch import
does this answer your question?help wanted

Description

Node version: 10.19.0 Sails version (sails): 1.2.3

Hi,

I have a controller which serves an image. I am trying to get this route to work

/content/26/image.png

It responses 404 but work with

/content/26/image.png/

I got it to work with a custom inline route ( fn: async function (req, res)) but I want access control for this route.

Many thanks in advance and kindest regards

Contributor guide

Tech stack
javascriptnodejs
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsSails framework
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate how Sails' router handles dots in route parameters by examining the source code in `lib/router/` and related configuration. Check if there is an existing option to allow dots in param values, and consider submitting a fix that updates the route matching regex or adds a flag. Review comments in the issue for any maintainer suggestions.