bafnetwork/baf-wallet-v2

Type checking when deserializing a string to an interface

Open

#36 opened on Apr 30, 2021

View on GitHub
 (0 comments) (0 reactions) (0 assignees)TypeScript (0 forks)auto 404
good first issuehygiene

Repository metrics

Stars
 (4 stars)
PR merge metrics
 (PR metrics pending)

Description

  • It would be nice if we had some type checking when desalinizing from a JSON string. This would especially be nice in avoiding undefined behavior with approve redirect
  • We could use a library like ts-interface-checker but this would require setting up some additional tooling
  • May be worth it in the end though...

Contributor guide

Research direction
Investigate how to integrate ts interface checker into the codebase for JSON deserialization, particularly for wallet related operations. Focus on setting up the library and adding type checks for interfaces used in deserialization paths.
Tech stack
typescript
Domain
full stack
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptJSON parsing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70