Switching reviews causes new comments to be invisible until page reload
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 35/100
Research direction
Reproduce the flow from a branch diff with existing reviews: add a comment, switch review links in the bottom dialog, and add another comment. Inspect the review-switch and comment-dialog behavior; done means the new review's comments appear immediately after switching, or switching is prevented once a review has started.
Written by the indexing model from the issue text.
Description
- Open a branch diff with existing reviews
- Add comment
- Clicks another review link on the bottom dialog
- Add another comment (click Comment in comment dialog)
Actual Result
Nothing happens. (But after reloading a page I see new unfinished reviews)
Expected Result
We should either prevent user from switching reviews after starting a new one. Or show the comments for the new review on switch.
- Dominant language
- PHP
- Stars
- 84
- Forks
- 14
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from badoo/codeisok
-
Dependency Dashboard Open
Difficulty 2/5 1-3 hours Newbie friendliness 25/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
enhancement
Difficulty 4/5 3-5 days Newbie friendliness 35/100
-
bug
Difficulty 4/5 3-5 days Newbie friendliness 35/100
Similar issues
-
tooling
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
UX
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
ProfessionalWiki/NeoWiki#1525 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
OpenConext/OpenConext-engineblock#2122 ·
-
Bug
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
Automattic/safe-publish#594 ·