badges/shields

DOMParser for dynamic xml badge spews log results in production

Open

#2658 opened on Jan 6, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (22,337 stars) (5,423 forks)batch import
good first issueservice-badge

Description

e.g.

@#[line:21,col:1]
[xmldom warning]        unclosed xml attribute
@#[line:22,col:1]
[xmldom warning]        unclosed xml attribute
@#[line:23,col:1]
[xmldom warning]        unclosed xml attribute
@#[line:24,col:1]
[xmldom error]  element parse error: Error: attribute value must after "="
@#[line:47,col:85]
[xmldom error]  element parse error: Error: invalid tagName:\
@#[line:47,col:232]
[xmldom warning]        unclosed xml attribute
@#[line:154,col:7]
[xmldom error]  entity not found: 
@#[line:212,col:143]
[xmldom error]  entity not found: 
@#[line:212,col:143]
[xmldom warning]        unclosed xml attribute
@#[line:299,col:31]
[xmldom warning]        attribute "selected" missed value!! "selected" instead!!
@#[line:342,col:14]
[xmldom error]  entity not found: 
@#[line:379,col:57]
[xmldom error]  entity not found: 

I imagine DOMParser is printing warnings by default. They have a way to provide our own error handler. Maybe we can use that to suppress these messages.

https://github.com/jindw/xmldom#api-reference

Contributor guide

Tech stack
javascriptnodejs
Domain
backend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic JavaScriptfamiliarity with xmldom library
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Look for the DOMParser usage in the dynamic badge generation code in the badges/shields repository. The issue provides a reference to the xmldom API for custom error handlers. Implement a custom error handler that suppresses or ignore the warnings and errors shown in the issue, ensuring production logs are clean. Test that badges still generate correctly.