entity_plus property callbacks still reference undefined Drupal 7 function names

Open Beginner friendly
#11 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
88/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
php
Domain
backend

Research direction

Inspect timefield_property_info_callback() and includes/entity_plus.property.inc to compare the defined entity_plus_property_verbatim_get/set names with the eight property-level callback references. Rename the remaining unprefixed references, then verify that no entity_property_verbatim_get/set references remain and that property reads and writes resolve correctly.

Written by the indexing model from the issue text.

Description

timefield_property_info_callback() sets getter callback / setter callback for the timefield properties. Issue #3 (released in 1.0.1) renamed the field-level pair to entity_plus_metadata_field_verbatim_get/set, but the property-level callbacks in the same function still use the Drupal 7 names entity_property_verbatim_get / entity_property_verbatim_set (8 occurrences).

entity_plus only defines the prefixed functions (entity_plus_property_verbatim_get/set in includes/entity_plus.property.inc); the unprefixed Drupal 7 names don't exist in Backdrop. So on any site that reads these properties (Rules conditions/actions, tokens, entity metadata), the getter/setter resolves to an undefined function.

Still present on both 1.x-1.0.1 and the 1.x-1.x dev tip.

Fix: rename the remaining entity_property_verbatim_get/set references in timefield_property_info_callback() to their entity_plus_ equivalents, matching what #3 did for the field pair.

Dominant language
JavaScript
Stars
0
Forks
3
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from backdrop-contrib/timefield

All issues in backdrop-contrib/timefield

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.