babel/minify

transform-remove-console: Flow declarations as bindings

Open

#874 opened on Jun 15, 2018

View on GitHub
 (1 comment) (7 reactions) (0 assignees)JavaScript (4,377 stars) (223 forks)batch import
help wanted

Description

Describe the bug

Using transform-remove console, I'm getting the following error when running the Metro Bundler for a react-native app:

transform[stderr]: 
transform[stderr]:         You or one of the Babel plugins you are using are using Flow declarations as bindings.
transform[stderr]:         Support for this will be removed in version 7. To find out the caller, grep for this
transform[stderr]:         message and change it to a `console.trace()`.
transform[stderr]:       
transform[stderr]: 
transform[stderr]:         You or one of the Babel plugins you are using are using Flow declarations as bindings.
transform[stderr]:         Support for this will be removed in version 7. To find out the caller, grep for this
transform[stderr]:         message and change it to a `console.trace()`.
transform[stderr]:       
transform[stderr]: 
transform[stderr]:         You or one of the Babel plugins you are using are using Flow declarations as bindings.
transform[stderr]:         Support for this will be removed in version 7. To find out the caller, grep for this
transform[stderr]:         message and change it to a `console.trace()`.
transform[stderr]:       
transform[stderr]: 
transform[stderr]:         You or one of the Babel plugins you are using are using Flow declarations as bindings.
transform[stderr]:         Support for this will be removed in version 7. To find out the caller, grep for this
transform[stderr]:         message and change it to a `console.trace()`.

To Reproduce

Make a react-native project, configure a .babelrc like:

{
	"comments": false,
	"ignore": ["node_modules/(?!react-navigation)"],
	"presets": ["react-native"],
	"plugins": [
		"transform-flow-strip-types",
		["transform-remove-console", { "exclude": ["error"] }]
		["react-intl", { "messagesDir": "./lang/messages/" }]
	],
	"sourceMaps": "inline"
}

Actual Output

See the above snippet.

Expected Output

No errors leaked out in the logs

Configuration

TypeScript 2.9, React-Native Project

babel-plugin-transform-remove-console: 6.9.4

babel version : 7.0.0-beta.51

babel-minify-config: N/A

babelrc:

Included above

Possible solution

Contributor guide

Tech stack
javascriptnodejsreact native
Domain
developer experiencetoolingbuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Babel plugin APIFlow type systemReact NativeAST traversal
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
The issue is in the babel plugin transform remove console plugin. Look at the plugin's source code (likely packages/babel plugin transform remove console/src/index.js). Find where Flow type declarations are used as bindings causing the deprecation warning. Update the code to use the new Babel 7 compatible approach. Consider testing with a React Native project as described in the issue. Check if there are any comments or linked issues for more context.