aws/copilot-cli

Allow firelens container "logging" to have `essential` set to "false"

Open

#3,255 opened on Feb 8, 2022

View on GitHub
 (10 comments) (0 reactions) (0 assignees)Go (3,737 stars) (441 forks)auto 404
good first issuesize/Stype/featuretype/request

Description

We recently had a job fail where the firelens container exited with a non-zero status and it took our main container with it. Is there a way to mark the firelens logging container as not essential? It obviously wouldn't be ideal but we want to avoid the job failing from any issues with firelens.

Contributor guide

Tech stack
goaws
Domain
infrastructure
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
GitGoAWS
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the firelens configuration template (likely in templates/ or pkg/) to locate where the 'essential' field is set to true for the logging container, and propose a mechanism to allow users to set it to false.