aws/copilot-cli

Env Stack fails with RoleName > 64

Open

#2,118 opened on Mar 29, 2021

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Go (3,737 stars) (441 forks)auto 404
good first issuetype/enhancement

Description

When creating the environment with the following options: copilot env init --app loooooooooooong-app-name --name loooooooooooooooong-svc-name --prod --region us-est-1 --import-vpc-id vpc-xxxxx --import-public-subnets subnet-xxxx,subnet-xxxx --import-private-subnets subnet-xxxxx,subnet-xxxx

The Stack fails with the error: CloudformationExecutionRole - 1 validation error detected: Value 'loooooooooooong-app-name-loooooooooooooooong-svc-name-CFNExecutionRole' at 'roleName' failed to satisfy constraint: Member must have length less than or equal to 64 (Service: AmazonIdentityManagement; Status Code: 400; Error Code: ValidationError; Request ID: fcbbe450-65fc-4cd5-b65b-1e9b539f22d7; Proxy: null)

Cfn Template: CloudformationExecutionRole: Metadata: 'aws:copilot:description': 'An IAM Role for AWS CloudFormation to manage resources' DeletionPolicy: Retain Type: AWS::IAM::Role Properties: RoleName: !Sub ${AWS::StackName}-CFNExecutionRole

Expected Behavior: Copilot CLI should validate that len(app-name) + len(svc-name) + len('-CFNExecutionRole') <= 64 and warn the user, before submiting the CFn template

Contributor guide

Tech stack
go
Domain
cli
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Find the code that constructs the CloudFormationExecutionRole name and add validation to ensure the combined length of app name, service name, and suffix does not exceed 64 characters.