aws/aws-cdk

(aws-ecr-assets): Dockerfile.dockerignore is not used

Open

#17,686 opened on Nov 24, 2021

View on GitHub
 (6 comments) (1 reaction) (0 assignees)TypeScript (3,530 forks)batch import
@aws-cdk/aws-ecr-assetsbuggood first issuein-progressp2

Repository metrics

Stars
 (10,710 stars)
PR merge metrics
 (Avg merge 14d 11h) (68 merged PRs in 30d)

Description

What is the problem?

.. instead .dockerfile needs to be present. Docker it self supports Dockerfile.dockerignore - which is useful when -f (dockerfile prop) is given

Reproduction Steps

new ecrAssets.DockerImageAsset(this, 'MyImage', {
            directory: path.join(__dirname, '..', '..'),
 });

What did you expect to happen?

Give -f MyDockerFile (dockerfile: MyDockerFile) then still .dockerignore is needed

What actually happened?

MyDockerFile.dockerignore is considered for exclusion

CDK CLI Version

1.130.0

Framework Version

No response

Node.js Version

16.13.0

OS

macOS

Language

Typescript

Language Version

4.5.2

Other information

No response

Contributor guide

Research direction
Modify the DockerImageAsset to detect and use a .dockerignore file named after the Dockerfile (e.g., MyDockerFile.dockerignore) when a custom Dockerfile is specified via the 'dockerfile' property.
Tech stack
typescript
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
AWS CDK basicsDocker build context
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60