Synchronization on value classes

Open Beginner friendly
#713 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
72/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Quiet
Tech stack
android, kotlin
Domain
mobile-dev

Research direction

Start with DefaultEglRenderer.kt at the aspectRatio field and its synchronization around line 26. Check how aspectRatio is accessed and determine whether synchronization should use a dedicated lock or be removed. Done means the renderer no longer synchronizes on the Float value and the project’s Android checks pass.

Written by the indexing model from the issue text.

Description

Hi,
I am Android platform developer and during JEP-401 work we've found that DefaultEglRenderer synchronizes on aspectRatio field whose type is java.lang.Float.

In a future release that will throw an exception.

Please take a look at that. Either use a dedicated java.lang.Object lock or remove synchronization altogether.

Thanks

Dominant language
Kotlin
Stars
113
Forks
60
Avg merge
42m
Merged PRs (30d)
5

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aws/amazon-chime-sdk-android

All issues in aws/amazon-chime-sdk-android

Similar issues

More Kotlin issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.