enhancement(registry): tighten adapter types, comments, and lifecycle coverage
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Refactor
- Clarity
- Mostly clear
- Activity status
- Active
- Tech stack
- typescript
Research direction
Read cdk/src/handlers/shared/registry/agent-registry-client.ts and cdk/src/handlers/registry-provisioning/index.ts, using PR #779 as context. Trace the delete lifecycle and the RegistryClient boundary before evaluating the type changes. Done means the comments are accurate, the adapter types reflect their consumers, and coverage proves non-retryable non-404 GetRegistry failures are rethrown.
Written by the indexing model from the issue text.
Description
Context
Consolidated non-blocking clarity and coverage follow-ups from the final review of PR #779.
Comment and documentation corrections
- Distinguish MCP
_metastorage from SKILLx-abca-runtimefrontmatter in the adapter header. - Correct the claim that duplicate YAML keys are parser errors under
js-yamlwith{ json: true }; the emitter prevents key injection by quoting/escaping caller-controlled values. - Include SKILL in the
resolvepath commentary. - Clarify that
waitPastCreatingwaits only until the record leavesCREATING, not until a terminal lifecycle state. - Clarify that
autoApprovegates only the final approval call; create and submit always occur.
Type cleanup
- Evaluate a discriminated representation linking registry
kindto its payload variant instead of a broadkind: stringshape. - Simplify
DeleteAttemptto the states its consumers need, or document why all current states are valuable.
Keep any public RegistryClient port change separately reviewable and compatible with the architecture boundary.
Coverage gap
Add a delete-lifecycle test proving isComplete rethrows a non-retryable, non-404 GetRegistry failure rather than treating it as absent or retryable.
References
- PR #779
cdk/src/handlers/shared/registry/agent-registry-client.tscdk/src/handlers/registry-provisioning/index.ts
- Dominant language
- TypeScript
- Stars
- 146
- Forks
- 46
- Avg merge
- 2d 10h
- Merged PRs (30d)
- 26
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from aws-samples/sample-autonomous-cloud-coding-agents
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
bug v1
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
bug v1
Difficulty 2/5 1-3 hours Newbie friendliness 80/100
-
documentation P2 security
Difficulty 2/5 1-2 days Newbie friendliness 74/100
-
documentation
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
aws-samples/sample-autonomous-cloud-coding-agents#767 · 2 comments ·
All issues in aws-samples/sample-autonomous-cloud-coding-agents
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
security
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
IBM/node-sdk-core#373 ·
-
e2e-failure ready-to-code
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
chore
Difficulty 2/5 1-3 hours Newbie friendliness 88/100