register_from_elb should be at hook ValidateService

Open
#85 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
aws, shell
Domain
cloud, devops

Research direction

Locate the CodeDeploy hook configuration that defines register_from_elb, then compare its current ApplicationStart placement with the ValidateService hook. Verify that registration is not repeated when validation fails and that the hook configuration reflects the intended lifecycle behavior.

Written by the indexing model from the issue text.

Description

Noticed that currently register_from_elb is placed in the hook ApplicationStart while it would make more sense to put it at ValidateService?
If Validate fails, you do not want to register it again to the ELB

Dominant language
Shell
Stars
639
Forks
777
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aws-samples/aws-codedeploy-samples

All issues in aws-samples/aws-codedeploy-samples

Similar issues

More Shell/Bash issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.