Add proxy configuration

Open

#75 opened on Jan 30, 2020 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty: 2/5
Estimated time: 1-3 hours
Newbie friendliness: 45/100

Issue type: Bug
Clarity: Clearly specified
Activity status: Stale
Tech stack: docker, python
Domain: build-system, devops

Research direction

Start at the cfn submit entry point and the _docker_build method in codegen.py. Confirm the Docker build behavior when a proxy is configured, and consider the issue complete when cfn submit succeeds through that proxy configuration.

Written by the indexing model from the issue text.

Description

enhancement help wanted p2

cfn submit doesn't seem to work if a proxy is configured. Adding use_config_proxy to the _docker_build method in codegen.py shown below seems to resolve the issue.

@classmethod
def _docker_build(cls, external_path):
    cls._check_for_support_lib_sdist(external_path)

    internal_path = PurePosixPath("/project")
    command = " ".join(cls._make_pip_command(internal_path))
    LOG.debug("command is '%s'", command)

    volumes = {str(external_path): {"bind": str(internal_path), "mode": "rw"}}
    image = f"lambci/lambda:build-{cls.RUNTIME}"
    LOG.warning(
        "Starting Docker build. This may take several minutes if the "
        "image '%s' needs to be pulled first.",
        image,
    )
    docker_client = docker.from_env()
    try:
        logs = docker_client.containers.run(
            image=image,
            command=command,
            auto_remove=True,
            volumes=volumes,
            stream=True,
            use_config_proxy=True   #<=== use proxy configuration if specified in config.json
        )

Dominant language: Python
Stars: 107
Forks: 46
PR merge metrics: No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

Read the whole issue, then the project's contributing guide.
Comment on the issue to say you are picking it up — it saves two people doing the same work.
Fork the repository and make your change on a branch.
Open a pull request that references the issue number.