Ensure that re-invocations are time/count limited

Open
#82 2 comments 0 reactions 1 assignee View on GitHub

@rjlohan is already working on this.

Since Jun 2, 2019.

Assessment

This issue has not been assessed yet.

Description

enhancement question

Currently, although CloudFormation will eventually timeout on waiting for a resource provisioning action, there is no constraint on the duration or number of re-invocations that can be scheduled, leading to essentially unbounded Lambda compute.

Wrapper should auto-inject a net runtime into the callback context and use this to compute a restriction and eventual timeout at https://github.com/aws-cloudformation/aws-cloudformation-rpdk-java-plugin/blob/master/src/main/java/com/aws/cfn/LambdaWrapper.java#L262

This timeout should probably be slightly less than the CloudFormation timeout to ensure that stack events reflect actual progress and termination of handler occurs before CloudFormation abandons the request.

Dominant language
Java
Stars
30
Forks
48
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aws-cloudformation/cloudformation-cli-java-plugin

All issues in aws-cloudformation/cloudformation-cli-java-plugin

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.