Incorrect CodeUri for sam build

Open
#272 0 comments 4 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
aws, java, python

Research direction

Start at python/rpdk/java/codegen.py#L49 and inspect how the generated template sets CodeUri. Run sam build against a generated Java project to reproduce the Not a directory error; done means the template uses the source directory and sam build completes successfully.

Written by the indexing model from the issue text.

Description

bug

https://github.com/aws-cloudformation/cloudformation-cli-java-plugin/blob/10e32d7b60f2395650900022e7d5e161481f5136/python/rpdk/java/codegen.py#L49

This CodeUri may be correct for other SAM commands, but if you run sam build it's incorrect. See https://github.com/awslabs/aws-sam-cli/issues/1278#issuecomment-512341533:

It looks like your CodeUri is a jar? It should be the directory of your source not the compiled artifact.

The error it gives:

Build Failed - Error: JavaMavenWorkflow:CopySource - [Errno 20] Not a directory: '/usr/aws-logs-loggroup/target/aws-logs-loggroup-handler-1.0-SNAPSHOT.jar

I fixed it by manually changing the template file:

CodeUri: ./target/aws-logs-loggroup-handler-1.0-SNAPSHOT.jar

to

CodeUri: .

Dominant language
Java
Stars
30
Forks
48
PR merge metrics
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aws-cloudformation/cloudformation-cli-java-plugin

All issues in aws-cloudformation/cloudformation-cli-java-plugin

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.