aweary/react-is-deprecated

Doesn't work with new 'prop-types' library

Open

#6 opened on Aug 24, 2017

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (6 forks)github user discovery
help wanted

Repository metrics

Stars
 (44 stars)
PR merge metrics
 (PR metrics pending)

Description

In the addIsDeprecated wrapper you iterate over all properties on the PropTypes object and call .bind() for each property. However, in the new prop-types library they added a self-reference of PropTypes into the PropTypes object which causes it to break since it's not a function. There is also a checkPropTypes which may also be problematic.

You can view their source here

Contributor guide

Research direction
Inspect the addIsDeprecated wrapper in the source code and modify the iteration over PropTypes properties to skip non function keys like the self reference and checkPropTypes.
Tech stack
javascript
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70