avh4/elm-format

Vim Integration seems to mess with how vim redraws the screen after a save.

Open

#93 opened on Dec 31, 2015

View on GitHub
 (11 comments) (0 reactions) (0 assignees)Haskell (148 forks)batch import
IDE integrationhelp wanted

Repository metrics

Stars
 (1,329 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I'm using elm-format ( elm-format 0.1-alpha3-dev ) with vim like this:

autocmd BufWritePost *.elm silent execute "!elm-format --yes %" | edit! | set filetype=elm

But on saving my display gets kind of messed up. Not really sure if this is a vim bug or something to do with elm-format, but when the format command exits the file gets redrawn sort of weird, everything gets shifted up a line. here's a screenshot of before saving:

conrad_ tmux _176x56

And now after saving:

broke

I can fix my screen by running :redraw!.

redrawn

I've found that I can get around this issue by adding > /dev/null to the end of the format command:

autocmd BufWritePost *.elm silent execute "!elm-format --yes % > /dev/null" | edit! | set filetype=elm

I feel like there is a more correct fix out there, or there is something else wrong with my vim configuration. Why is this happening? What's the right way to fix this?

Contributor guide

Research direction
Examine the output of elm format when run non interactively; it may output terminal control sequences or extra newlines that disrupt vim's display. Test with and without output redirection to identify the cause.
Tech stack
None
Domain
developer experiencecli
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
VimElm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70