avh4/elm-format

Refactor to prevent mismatched newline tracking

Open

#164 opened on May 8, 2016

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Haskell (1,329 stars) (148 forks)batch import
help wanted

Description

pushNewlineContext : IParser ()
popNewlineContext : IParser Bool

should be replaced with Parse.Common.checkMultiline

Contributor guide

Tech stack
None
Domain
tooling
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Haskell basicselm format internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
20
Research direction
Identify the locations of pushNewlineContext and popNewlineContext in the Haskell parser code (likely in a module like Parser/Newline.hs). Replace their usage with Parse.Common.checkMultiline. Ensure the newline tracking behavior is unchanged by verifying existing tests pass.