avast/gradle-docker-compose-plugin

0.17.5 does not work with docker-compose 2.21.0 from docker desktop

Open

#424 opened on Sep 28, 2023

View on GitHub
 (4 comments) (1 reaction) (0 assignees)Groovy (429 stars) (103 forks)batch import
help wanted

Description

With latest version (0.17.5 as of this issue), when using docker-compose v2.18.1, everything works fine. When docker-compose is updated to 2.21.0 (thru docker-desktop), we are getting:

> Task :composeUp FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':composeUp'.
> docker-compose version 0.0.0 doesn't support --scale option

relevant parts of stack-trace:

Caused by: java.lang.UnsupportedOperationException: docker-compose version 0.0.0 doesn't support --scale option
        at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance0(Native Method)
        at java.base/jdk.internal.reflect.NativeConstructorAccessorImpl.newInstance(NativeConstructorAccessorImpl.java:77)
        at java.base/jdk.internal.reflect.DelegatingConstructorAccessorImpl.newInstance(DelegatingConstructorAccessorImpl.java:45)
        at org.gradle.internal.classpath.intercept.CallInterceptorsSet$DecoratingCallSite.access$401(CallInterceptorsSet.java:128)
        at org.gradle.internal.classpath.intercept.CallInterceptorsSet$DecoratingCallSite$4.callOriginal(CallInterceptorsSet.java:180)
        at org.gradle.internal.classpath.intercept.CallInterceptorsSet$1.doIntercept(CallInterceptorsSet.java:54)
        at org.gradle.internal.classpath.intercept.CallInterceptorsSet$DecoratingCallSite.callConstructor(CallInterceptorsSet.java:177)
        at com.avast.gradle.dockercompose.ComposeExecutor.isScaleSupported(ComposeExecutor.groovy:274)
        at com.avast.gradle.dockercompose.ComposeExecutor$isScaleSupported$0.call(Unknown Source)
        at com.avast.gradle.dockercompose.tasks.ComposeUp.up(ComposeUp.groovy:129)
        at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)

Contributor guide

Tech stack
groovydocker
Domain
devopstesting
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of Gradle and GroovyUnderstanding of Docker Compose versioning
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
The issue is in the ComposeExecutor.groovy file, specifically in the `isScaleSupported` method (line 274). The problem is that the version detection fails for docker compose v2.21.0, returning '0.0.0'. Investigate how the plugin parses the output of 'docker compose version' and update the parsing logic to handle the new version format. Consider reviewing the Docker Compose release notes to understand version output changes.