avajs/ava

Line number parser doesn't utilize @ava/typescript's compilation output

Open

#3064 opened on Jul 10, 2022

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (20,600 stars) (1,408 forks)batch import
bughelp wantedscope:globbingscope:internalsscope:typescript

Description

Line number selection doesn't use the @ava/typescript provider to resolve the compiled JS file. This means it's parsing the actual TypeScript file which is not supported:

https://github.com/avajs/ava/blob/ac0d75d05d28e511b1b3654b09d11d602e360179/lib/worker/base.js#L42-L51

We'd need to amend the worker interface to make the file resolver available:

https://github.com/avajs/typescript/blob/34da7bf008bd94e4844562ed86f5446faae6c087/index.js#L152-L168

This requires a new protocol identifier, and the file resolver should only be called if available to retain compatibility with the current @ava/typescript version. I can explain more when we get to this point:

https://github.com/avajs/ava/blob/ac0d75d05d28e511b1b3654b09d11d602e360179/lib/provider-manager.js#L12-L14

We can then install the providers earlier:

https://github.com/avajs/ava/blob/ac0d75d05d28e511b1b3654b09d11d602e360179/lib/worker/base.js#L123-L132

Contributor guide

Tech stack
javascripttypescript
Domain
testing
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
AVA test runner basicsTypeScript compilationNode.js worker interface
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the line number parser in lib/worker/base.js (lines 42-51) and understand how it currently resolves file paths. Examine the @ava/typescript provider's file resolver in its index.js (lines 152-168) and the worker interface. Determine how to pass the file resolver to the worker and when to install providers, as outlined in the issue's references to base.js and provider manager.js. Ensure compatibility with the current @ava/typescript version by conditionally calling the file resolver only if available. Relevant comments in the issue provide additional context, but no maintainer questions have been posed yet.