avajs/ava

Feature Request: A way to mark a test 'skipped' after it starts

Open

#2,010 opened on Jan 9, 2019

View on GitHub
 (12 comments) (2 reactions) (0 assignees)JavaScript (20,600 stars) (1,408 forks)batch import
enhancementhelp wantedscope:assertions

Description

Description

I'm using ava to control selenium-webdriver for tests run in Firefox and Chrome. It cannot be known synchronously if the browser can be run. An example flow could be:

test('somepage.html', async t => {
  try {
    await loadPage('somepage.html');
  } catch (error) {
    t.skip();
    return;
  }
  // testing against the page here
});

In this example loadPage() will reject if the browser cannot be started, otherwise it will resolve. The goal is that the test will report skipped if the browser cannot be run.

It would probably be good if t.skip() threw an exception if any assertions have already run for that test.

Environment

Node.js v10.14.2
linux 4.19.8-200.fc28.x86_64
ava 1.0.1
npm 6.4.1

Contributor guide

Tech stack
javascriptnodejs
Domain
testing
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptNode.jsbasic understanding of test runner lifecycle
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue requests adding a programmatic skip method that can be called after a test has started. To implement, one should first explore the existing test API in ava, particularly the test object and how skip is currently handled (likely via a flag before test execution). The body suggests that t.skip() should throw an error if assertions have already run, so a mechanism to track whether any assertions have been made is needed. Comments on the issue may contain further discussion on implementation approaches. Key files to examine include the test execution code and the test object implementation.