avajs/ava

Log test duration for serial tests only

Open

#1,668 opened on Jan 29, 2018

View on GitHub
 (20 comments) (0 reactions) (0 assignees)JavaScript (20,600 stars) (1,408 forks)batch import
enhancementhelp wantedscope:internalsscope:reporters

Description

I'm thinking of revisiting #971, but with a twist.

Reporting test duration when tests run concurrently can be misleading, since slow, synchronous code in one test also slows down another. This is why I've been hesitant of exposing the duration numbers in the TAP reporter.

Oddly though we do show durations in the verbose reporter! This has survived all the way from #30.

I wonder if we should only show durations when --serial is used. This way the numbers will be more accurate and users will be less tempted to fix one "slow" test while the problem is another. We can then also include it in the TAP output.

Contributor guide

Tech stack
javascriptnodejs
Domain
testingcliperformance
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic understanding of AVAFamiliarity with reporter implementationUnderstanding of concurrent vs serial execution
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Review the verbose reporter code (likely in lib/reporter/verbose.js or similar) to identify where durations are printed. Examine the CLI option parsing for serial (maybe in cli.js). Understand the relationship between concurrent and serial test execution as discussed in issues #971 and #30. Implement a conditional to log durations only when serial is active.