avajs/ava

Log test duration for serial tests only

Open

#1,668 opened on Jan 29, 2018

View on GitHub
 (20 comments) (0 reactions) (0 assignees)JavaScript (1,408 forks)batch import
enhancementhelp wantedscope:internalsscope:reporters

Repository metrics

Stars
 (20,600 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I'm thinking of revisiting #971, but with a twist.

Reporting test duration when tests run concurrently can be misleading, since slow, synchronous code in one test also slows down another. This is why I've been hesitant of exposing the duration numbers in the TAP reporter.

Oddly though we do show durations in the verbose reporter! This has survived all the way from #30.

I wonder if we should only show durations when --serial is used. This way the numbers will be more accurate and users will be less tempted to fix one "slow" test while the problem is another. We can then also include it in the TAP output.

Contributor guide

Research direction
Inspect the verbose reporter and TAP reporter implementation to locate where test duration is displayed. Add a condition to show durations only when the ` serial` flag is used.
Tech stack
javascriptnodejs
Domain
testing
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.jsGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75