IAT payload value is not respected if value is zero
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 58/100
- Issue type
- Bug
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- javascript, node.js
Research direction
Start at sign.js around line 179, where the issue identifies the handling of the iat payload value. Reproduce the example with iat set to 0 and expiresIn set to 86400, then verify that the payload keeps iat at 0 and calculates exp as 86400. Add or update coverage for this zero-value case if the repository's existing tests identify a suitable location.
Written by the indexing model from the issue text.
Description
Description
If the iat payload value is is zero, in other words, the UNIX epoch, it is not respected and the current time is used instead. I believe it is because zero evaluates to false here:
https://github.com/auth0/node-jsonwebtoken/blob/master/sign.js#L179
Reproduction
jwt.sign({
iat: 0,
data: 'foobar'
}, 'secret', {
expiresIn: 86400
});
Expected payload iat value should be zero and exp is expected to be 86400. The actual iat value is the current time and exp is the current time plus 86400.
Environment
- Version: 9.0.0
- Node v14.18.1 (npm v8.12.2)
- Dominant language
- JavaScript
- Stars
- 18.2k
- Forks
- 1.3k
- PR merge metrics
- No merged PRs in 30d
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from auth0/node-jsonwebtoken
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
auth0/node-jsonwebtoken#1042 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
auth0/node-jsonwebtoken#1000 · 2 comments · 1 reaction ·
-
Difficulty 4/5 3-5 days Newbie friendliness 65/100
auth0/node-jsonwebtoken#1046 ·
-
Difficulty 5/5 Over a week Newbie friendliness 10/100
auth0/node-jsonwebtoken#1034 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
auth0/node-jsonwebtoken#1032 ·
All issues in auth0/node-jsonwebtoken
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
antfu-collective/icones#398 ·
-
ECmail.com Open
Difficulty 1/5 Under an hour Newbie friendliness 90/100
wesbos/burner-email-providers#554 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 65/100
radiantearth/stac-browser#1023 ·
-
HMR stops working Open
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
components-web-app/docs#92 ·