ausocean/cloud

extStop should return error if OffActions is empty

Open

#409 opened on Dec 20, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Go (3 forks)auto 404
P2enhancementgood first issue

Repository metrics

Stars
 (1 star)
PR merge metrics
 (PR metrics pending)

Description

Currently if extStop finds that there are no off actions there is no logging and nil returned. However, extStops sole purpose is to stop the hardware. If this has been called and there are no off actions, then it seems erroneous to return nil as if there are no problems, when in fact stop couldn't happen. We should therefore return an error in this circumstance, and if we don't care we can just ignore this particular error.

Contributor guide

Research direction
Investigate the extStop function and its callers. Determine how OffActions is set and ensure an error is returned when empty. Update tests if necessary.
Tech stack
go
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Go
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75