setTimout is evil ;-)

Open
#96 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
testing

Research direction

The issue points to src/component-tester.ts#L82; start by inspecting the setTimeout and how tests use sinon fakeTimers or the Aurelia task queue. Done means removing the problematic timeout without breaking component-test timing, with the existing component tests still passing.

Written by the indexing model from the issue text.

Description

Hi,
Can the setTimeout be removed from here please?

If this has been replaced with sinon fakeTimers this just causes all manner of problems.

Why is it there and can it be replaced by the aurelia task queue?

Ta,
John

Dominant language
TypeScript
Stars
38
Forks
27
No merged PRs in 30d

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from aurelia/testing

All issues in aurelia/testing

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.