aurbano/robinhood-node

Security

Open

#116 opened on Nov 26, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (696 stars) (215 forks)batch import
help wanted

Description

I downloaded the latest version 1.7.0 and noticed there were 75 vulnerabilities in this project. 27 of them were HIGH. Given the nature of this library and the potential to expose someone's financial information I wanted to mention this. I will also review the use of lodash, should, uuid, and request to make sure they are malicious.

By removing the following dev dependencies they seem to be resolved:

npm uninstall ava
npm uninstall coveralls
npm uninstall nyc
npm unisntall standard-version

Contributor guide

Tech stack
nodejsjavascript
Domain
security
Issue type
security
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
npmdependency management
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Run `npm audit` to confirm vulnerabilities in the current dependencies. Examine package.json to evaluate the suggested removal of ava, coveralls, nyc, and standard version. Update package.json and package lock.json to remove these dev dependencies if safe, or update to patched versions. Check the repository's existing security policies.