aurbano/react-ds

Pass endPoint as second argument of onSelectionChange

Open

#46 opened on Oct 29, 2019

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (18 forks)github user discovery
help wanted

Repository metrics

Stars
 (164 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Having the endPoint as second argument of onSelectionChange could help with some UX stuff, like popping up some actions panel for highlighted elements in that point. Atm an additional listener is required to accomplish this.

Contributor guide

Research direction
Find the onSelectionChange callback usage in the component and add the endPoint as the second argument. Then update any documentation or types accordingly.
Tech stack
javascriptreact
Domain
frontend
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptReact
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85