atuinsh/atuin

`atuin import zsh` imports history in reverse order?

Open

#178 opened on Sep 1, 2021

View on GitHub
 (4 comments) (4 reactions) (0 assignees)Rust (29,714 stars) (840 forks)batch import
bughelp wantedshell-zsh

Description

I've just installed atuin in my Ubuntu 20.04, ZSH 5.8 pc using the deb package in Releases.

Running atuin import zsh (or auto) successfully imports my command history, but the imported commands then show up in reverse order when searching it through atuin. That makes no sense... Commands saved after the import and correctly appended to the history file appear in the right order.

Is it a timestamping issue? My history file had no timestamp or extra info, just the plain commands. I noted that atuin adds timestamps to ZSH history file.

For now, I've just reverted the history file with tac before importing and got it done. 👍🏼

Contributor guide

Tech stack
rustshell
Domain
clibackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Rustshell scriptingatuin basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the import logic for zsh history in the atuin source code, likely in src/import.rs. The issue suggests that commands are imported in reverse order, possibly due to missing or incorrect timestamps. Look at how the history file is parsed and how timestamps are assigned. Also consider if the order of insertion in the database affects search results. Check if there are any tests for import functionality. Review the zsh history format without timestamps and how atuin adds them. Propose a fix that ensures correct ordering, either by sorting by timestamp or preserving the order from the history file.