atuinsh/atuin

Installer script detects Fedora as Ubuntu when running in WSL

Open

#1,083 opened on Jul 3, 2023

View on GitHub
 (4 comments) (0 reactions) (0 assignees)Rust (29,714 stars) (840 forks)batch import
help wanted

Description

I’m the atypical user who runs Fedora in WSL, not the de-facto standard Ubuntu. However, if the install sript sees microsoft in the kernel version it assumes that Ubuntu is installed.

Contributor guide

Tech stack
rustshell
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
shell scriptingLinux distro detection
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The installer script currently checks the kernel version for 'microsoft' and assumes Ubuntu. To fix, read /etc/os release to get the actual distro ID and set the appropriate package manager (e.g., dnf for Fedora). The relevant file is likely in the repository's scripts directory, such as install.sh. See comments in issue #1083 for additional context.
Installer script detects Fedora as Ubuntu when running in WSL · atuinsh/atuin#1083 | Good First Issue