atom/teletype

Status bar icon is not horizontally centered

Open

#217 opened on Nov 16, 2017

View on GitHub
 (3 comments) (1 reaction) (0 assignees)JavaScript (2,400 stars) (416 forks)batch import
bughelp wantedpriority:low

Description

Prerequisites

  • Put an X between the brackets on this line if you have done all of the following:

Description

The icon in the status bar is not horizontally centered due to a margin-right: .25em added by one-light-ui.

Steps to Reproduce

  1. Use a One theme
  2. Look closely at teletype icon in the status bar

Expected behavior:

teletype-icon-centered

Actual behavior:

teletype-icon-not-centered

Reproduces how often: 100%

Versions

Atom    : 1.24.0-dev-192cde85a
Electron: 1.6.15
Chrome  : 56.0.2924.87
Node    : 7.4.0

Contributor guide

Tech stack
htmlcss
Domain
frontenddesktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
basic CSS knowledge
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
The issue is a UI alignment bug in the teletype status bar icon. The icon is not horizontally centered because `one light ui` adds a `margin right: .25em`. To fix, locate the CSS rule for the status bar icon in the teletype package (likely in `styles/` directory) and add a rule to override the margin (e.g., `margin right: 0`) or use flexbox centering. Check the existing style files for similar overrides.