atom/github

consistently use `Timeago` component to humanize timestamps

Open

#1,905 opened on Jan 11, 2019

View on GitHub
 (4 comments) (0 reactions) (1 assignee)JavaScript (1,069 stars) (469 forks)batch import
code-cleanup :wrench:good first issue

Description

We have this sweet Timeago component that humanizes a timestamp, and then keeps that data up to date.

I did not know about Timeago, when we were making the CommitDetailView and the PullRequestCommitView. It would be good to make those components use Timeago, and also see if there's anywhere else that needs to be cleaned up.

Contributor guide

Tech stack
javascript
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85
Research direction
Look for where timestamps are displayed in `CommitDetailView` and `PullRequestCommitView` and replace them with the existing `Timeago` component. Also search the codebase for other manual timestamp formatting to ensure consistency. The `Timeago` component is located somewhere in the repository; check its usage in other views for reference.