atom/github

Click Staged/Unstaged Changes header to select all files

Open

#1,800 opened on Nov 15, 2018

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (1,069 stars) (469 forks)batch import
good first issuepapercut

Description

In at least couple of user interviews I participated in, the user tried to select all files by clicking the header. This behavior would be consistent with what we have in the ChangedFileItem where clicking a hunk header highlights all the changed lines in the hunk

Contributor guide

Tech stack
javascript
Domain
frontenddeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with Atom package developmentBasic knowledge of Git staging UI
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the Click handling in the ChangedFileItem component (likely in packages/github/lib/views/ changed file item.js) to see how hunk header clicks select all lines. Then apply similar logic to the Staged/Unstaged Changes header components (e.g., staged changes view and unstaged changes view). The issue mentions that users expect clicking the header to select all files, so look at the header's click event and implement a handler that checks all file checkboxes within that section.