atom/github

Inconsistency in symlink path

Open

#1,761 opened on Oct 25, 2018

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,069 stars) (469 forks)batch import
good first issue

Description

Some symlink diffs show the symlink destination path as a relative path, others as an absolute path. It'd be nice to be consistent.

as per @kuychaco:

Here's a tiny inconsistency in how we present the symlink path (relative vs. absolute) -- no big deal really, just wanted to point it out. We don't have to resolve it for this PR. Could make a good first issue for someone in the community if we don't get around to it before merge.

symlink-path-inconsistency

Originally reported by @kuychaco in https://github.com/atom/github/pull/1512#issuecomment-430437777.

Contributor guide

Tech stack
javascript
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Atom plugin developmentsymlinks
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90
Research direction
The issue requires making symlink destination paths consistent (relative vs. absolute) in the diff view. Refer to the screenshot and the comment at https://github.com/atom/github/pull/1512#issuecomment 430437777. The fix likely involves locating the code that renders symlink paths in the Atom GitHub package, standardizing the format.