atom/github

Replace getDerivedStateFromProps with memoization

Open

#1611 opened on Jul 26, 2018

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,069 stars) (469 forks)batch import
code-cleanup :wrench:good first issue

Description

Where possible, it would be cleaner and less error-prone to replace components that implement static getDerivedStateFromProps() with PureComponents or memoize-one:

Contributor guide

Tech stack
javascriptreact
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic React knowledgeUnderstanding of memoization
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Search the codebase for components that implement the getDerivedStateFromProps lifecycle method. In each case, evaluate whether the derived state can be computed using memoization with memoize one or by converting to a PureComponent. Follow the guidance in the linked React blog post. Ensure test coverage for the affected components. Since the issue is from 2018, verify that the components still exist and the pattern is still applicable.