Check if conn.commit() is required

Open
#103 0 comments 0 reactions 1 assignee View on GitHub

@dr-rodriguez is already working on this.

Since Jul 22, 2025.

Assessment

This issue has not been assessed yet.

Description

bug

We have several methods that load data into the database from the JSON files. Because we have been using SQLite a lot, we typically don't encounter issues. However, other databases may explicitly require us to use conn.commit() or similar to commit things like inserts or updates to the database. This is a newer requirement of SQLAlchemy 2.0. I think this is an un-caught bug in our codebase.

We should run some tests with a Postgres database to see if this is indeed the case and add them as part of the underlying methods.

Dominant language
Python
Stars
12
Forks
5
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from astrodbtoolkit/AstrodbKit

All issues in astrodbtoolkit/AstrodbKit

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.