astral-sh/ruff

INP001 false positive in tests folder

Open

#6,474 opened on Aug 10, 2023

View on GitHub
 (11 comments) (8 reactions) (0 assignees)Rust (2,088 forks)batch import
help wanted

Repository metrics

Stars
 (47,527 stars)
PR merge metrics
 (Avg merge 3d 8h) (573 merged PRs in 30d)

Description

The recommended Python + Pytest layout is

  • src/
    • mypkg/
      • __init__.py
      • subpkg/
        • __init__.py
  • tests/
    • test_thing.py
    • test_more/
      • test_other_thing.py

Notably, tests and all files under it aren’t packages. The recommended import mode enforces that you can’t import from them.

Therefore INP001 shouldn’t trigger when tests is on top level of the project.

In fact, it would be great to have both a rule that enforces the opposite and to ensure that tests/**/test_*.py files don’t import things from each other.

Contributor guide

Research direction
Investigate the INP001 rule logic to determine why it flags tests/ as a package and adjust to treat tests/ as a special top level directory.
Tech stack
pythonrust
Domain
developer experiencebackend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonRust
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70