astral-sh/ruff

autofix for flake8-use-pathlib (PTH) rules

Open

#2,331 opened on Jan 29, 2023

View on GitHub
 (17 comments) (5 reactions) (0 assignees)Rust (47,527 stars) (2,088 forks)batch import
fixeshelp wanted

Description

I enabled PTH rules and there was a few hits in rotki's codebase.

This is a rule I woud like to enforce but there is quite many places it hit and I suppose at least some of the rules should be autofixable. So if possible it would be cool to have ruff do it for us.

Contributor guide

Tech stack
pythonrust
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
PythonRustruff internalspathlib
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue requests autofix for flake8 use pathlib (PTH) rules. There are no linked PRs. The 17 comments likely discuss design and feasibility. To contribute, one should first understand ruff's current autofix infrastructure, particularly how rules are defined and how autofixes are implemented. Examine existing autofix implementations for similar rules to understand the pattern. The main challenge is generating correct Python code transformations using pathlib. The implementation would involve modifying the rule's definition in the ruff codebase to include an autofix function.
autofix for flake8-use-pathlib (PTH) rules · astral-sh/ruff#2331 | Good First Issue