astral-sh/ruff

Cleanup Ruff's CLI tests

Open

#19016 opened on Jun 28, 2025

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Rust (47,527 stars) (2,088 forks)batch import
help wantedtesting

Description

Ruff's CLI integration tests (crates/ruff/tests) contain a lot of shared boilerplate code (shared between test functions but also test files). We should try to extract those into a more reusable testing infra. I think ty's CLI test infra works pretty well and we should try if we can use the same structure for ruff.

https://github.com/astral-sh/ruff/blob/1f27d53fd576e92a7d2cd4abc1761d6ad836d85b/crates/ty/tests/cli/main.rs#L600

Contributor guide

Tech stack
rust
Domain
clitesting
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
RustCargoCLI testing patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the existing test files in crates/ruff/tests to identify repeated boilerplate. Review the referenced ty CLI test infrastructure at https://github.com/astral sh/ruff/blob/1f27d53fd576e92a7d2cd4abc1761d6ad836d85b/crates/ty/tests/cli/main.rs#L600 for structural inspiration. Extract common patterns into reusable functions or modules, and consider consulting maintainer feedback if scope is unclear.