astral-sh/ruff

Fixing file with rules E302, I001 cause infinite loop

Open

#12,611 opened on Aug 1, 2024

View on GitHub
 (3 comments) (1 reaction) (1 assignee)Rust (47,527 stars) (2,088 forks)batch import
bugfuzzerhelp wanted

Description

ruff 0.5.5+379 (a3e67abf4 2024-07-31)

ruff check *.py --select E302,I001 --no-cache --fix --unsafe-fixes --preview --output-format concise --isolated

file content(at the bottom should be attached raw, not formatted file - github removes some non-printable characters, so copying from here may not work):

import time
#替换环境

#测试环境，替换eb部分3台服务器及其代码
def web_replace():
    bg=time.time()

error

/tmp/tmp_folder/data/5053444380204826248.py:1:1: I001 Import block is un-sorted or un-formatted
Found 501 errors (500 fixed, 1 remaining).
[*] 1 fixable with the --fix option.

debug error: Failed to converge after 500 iterations in `/tmp/tmp_folder/data/5053444380204826248.py` with rule codes I001:---
import time


#替换环境

#测试环境，替换eb部分3台服务器及其代码
def web_replace():
    bg=time.time()
---

Ruff build, that was used to reproduce problem(compiled on Ubuntu 22.04 with relase mode + debug symbols + debug assertions + overflow checks) - https://github.com/qarmin/Automated-Fuzzer/releases/download/Nightly/ruff.7z

python_compressed.zip

Contributor guide

Tech stack
pythonrust
Domain
clitooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
4
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Pythonrufflinting
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
Examine the fix convergence logic in the ruff linter, particularly how rules E302 and I001 interact. Look at the source files for these rules (likely in `crates/ruff linter/src/rules/`). Review comments in the issue for insights from maintainers. Consider adding a test case that reproduces the infinite loop.
Fixing file with rules E302, I001 cause infinite loop · astral-sh/ruff#12611 | Good First Issue