astral-sh/ruff

Missing config option for `extend_external`

Open

#11,921 opened on Jun 18, 2024

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Rust (47,527 stars) (2,088 forks)batch import
configurationhelp wanted

Description

I have two configs, base.toml that is shared for multiple projects, and my in-project pyproject.toml that extends the one above.

It would be nice if the external could also be extended, much like select and ignore.

Contributor guide

Tech stack
rustpython
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Rust programmingRuff codebase basicsConfig extension mechanism
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate Ruff's configuration loading logic in `src/settings/` and `src/lib.rs`. Specifically, understand how `extend` and `external` are currently handled. Examine the implementation for `select` and `ignore` that support extension via `extend external`. Propose a similar mechanism for `extend external` by modifying the config parsing and merging logic.
Missing config option for `extend_external` · astral-sh/ruff#11921 | Good First Issue